New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shape detection #632
Shape detection #632
Conversation
This reverts commit 32588e6.
@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel. A member of the Team first needs to authorize it. |
Can you please merge this by updating (sync) your develop branch, use git merge |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
app/lib/handlers/pen.dart
Outdated
} | ||
|
||
default: | ||
// Manage custom shapes here | ||
} | ||
} else if (points.length > 500) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand why else if and not else?
If points < 500 and it doesn't recognize anything it clears it?
I don't think that's really good.
I would just make a guard clause and return if element == null or points > 500 (but I would remove this once we fixed the issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a leftover. Else enough. If you can change it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing!
No description provided.