Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape detection #632

Merged
merged 19 commits into from Mar 21, 2024
Merged

Shape detection #632

merged 19 commits into from Mar 21, 2024

Conversation

MrGumpIT
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 16, 2024

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

@CodeDoctorDE
Copy link
Member

Can you please merge this by updating (sync) your develop branch, use git merge
and remove this file while merging and then run dart run build_runner build inside api?

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
butterfly ✅ Ready (Inspect) Visit Preview Mar 21, 2024 3:01pm

app/lib/handlers/pen.dart Outdated Show resolved Hide resolved
app/lib/handlers/pen.dart Outdated Show resolved Hide resolved
}

default:
// Manage custom shapes here
}
} else if (points.length > 500) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand why else if and not else?
If points < 500 and it doesn't recognize anything it clears it?
I don't think that's really good.

I would just make a guard clause and return if element == null or points > 500 (but I would remove this once we fixed the issue)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a leftover. Else enough. If you can change it as well

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

@CodeDoctorDE CodeDoctorDE merged commit 1e596fb into LinwoodDev:develop Mar 21, 2024
14 checks passed
@MrGumpIT MrGumpIT deleted the shapeDetection branch April 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants