Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing outside window#521 #646

Merged
merged 14 commits into from Mar 27, 2024

Conversation

MrGumpIT
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 26, 2024

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

@CodeDoctorDE
Copy link
Member

i will test it tomorrow but here you should also remove the pubspec.lock change

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
butterfly ✅ Ready (Inspect) Visit Preview Mar 27, 2024 7:41pm

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't see a difference between the current version and your changes.

@@ -11,6 +11,7 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter/foundation.dart' as foundation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foundation is already imported in line 9, just use kIsWeb.

@MrGumpIT
Copy link
Contributor Author

MrGumpIT commented Mar 27, 2024

You need to remove: #521 (comment)
onExit: kIsWeb
? (event) => cubit.resetInput(
context.read())
: null,

@CodeDoctorDE
Copy link
Member

Surprisingly it really works, thanks.
I really don't know why this bug exists.
I will merge this!

@CodeDoctorDE CodeDoctorDE merged commit 7f69740 into LinwoodDev:develop Mar 27, 2024
14 checks passed
@MrGumpIT MrGumpIT deleted the DrawingOutsideWindow#521 branch April 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants