Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the background.md file to be more informative #652

Merged
merged 32 commits into from
May 6, 2024

Conversation

yotama9
Copy link
Contributor

@yotama9 yotama9 commented Mar 31, 2024

  • Updated the documentation for the Shortcuts readme page
  • changed the empty mode from 'disabled' to 'unchaged' in the shortcut documentations
  • minor fix to the shortcut readme file
  • updated the read.me file to include explanation about the welcome interface and the various elements of it
  • minor text fix
  • installed phosphor icons
  • Update docs/docs/README.md
  • Update docs/docs/README.md
  • Update docs/docs/README.md
  • completed the introduction section of the Readme file
  • tried to add tabsynch
  • added tab sync to README file
  • fixed some typos
  • Update docs/docs/README.md
  • Update docs/docs/README.md
  • Apply suggestions from code review
  • Bump softprops/action-gh-release from 1 to 2 (Bump softprops/action-gh-release from 1 to 2 #628)
  • edit the area description
  • Improve page feature and fix web file fetching
  • Add id to element
  • Add elements layer changed id
  • fixed(?) the lock file
  • Bump follow-redirects from 1.15.5 to 1.15.6 in /docs (Bump follow-redirects from 1.15.5 to 1.15.6 in /docs #631)
  • Update android build configuration
  • Add advance button for quickstart
  • Fix missing scrolling in export pdf select dialogs, closes [Bug]: Areas exports #633
  • Add setting for toolbar size, related to [Feature request]: custom resizeable toolbar & multiple columns and multi row supported toolbar  #589
  • Improve export pdf dialog
  • Fixed some formatting issues
  • Update docs/docs/areas.md
  • Transferred some suggestions
  • Updated the background.md file to be more informative

yotama9 and others added 26 commits February 14, 2024 23:08
Co-authored-by: Luciogi <84625092+Luciogi@users.noreply.github.com>
Co-authored-by: Luciogi <84625092+Luciogi@users.noreply.github.com>
Co-authored-by: Luciogi <84625092+Luciogi@users.noreply.github.com>
Co-authored-by: CodeDoctor <codedoctor@linwood.dev>
Co-authored-by: CodeDoctor <codedoctor@linwood.dev>
Co-authored-by: CodeDoctor <codedoctor@linwood.dev>
Co-authored-by: CodeDoctor <codedoctor@linwood.dev>
Copy link

vercel bot commented Mar 31, 2024

@yotama9 is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented Mar 31, 2024

i will look at it tomorrow,
for the next time please sync your branch with the latest develop branch before making changes, otherwise you will end up adding all your changes on every pr

(there are conflicts in the pnpm lock file, can you please fix that?)

@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented Apr 1, 2024

Can you please run

git fetch
git merge upstream/develop
cd docs
pnpm i
git push

@CodeDoctorDE
Copy link
Member

Can you please run

git fetch
git merge upstream/develop
cd docs
pnpm i
git push

@yotama9 Can you please run this so I'm able to merge this? Please use their changes when merging other files you didn't changed here.

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few things i would change

docs/docs/background.md Show resolved Hide resolved
docs/docs/background.md Show resolved Hide resolved
docs/docs/background.md Outdated Show resolved Hide resolved
docs/docs/settings2.md Outdated Show resolved Hide resolved
Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the problems myself because the new version will be released soon.
I forgot to say that you need to run git fetch upstream instead of just git fetch. thanks for your help!

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
butterfly ✅ Ready (Inspect) Visit Preview May 6, 2024 8:15pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Areas exports
2 participants