Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML and JSON export #60

Closed
Lion-Craft opened this issue Oct 15, 2023 · 3 comments · Fixed by #125
Closed

XML and JSON export #60

Lion-Craft opened this issue Oct 15, 2023 · 3 comments · Fixed by #125
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Version 3.0

Comments

@Lion-Craft
Copy link
Owner

Recently data export as Text was implemented thus it would also be useful to add XML and JSON exports which could also be created via a cmd argument if other applicatios want to use the data.
@Lion-Craft Lion-Craft added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2023
@Lion-Craft Lion-Craft mentioned this issue Oct 15, 2023
Closed
@magicalunicor
Copy link
Contributor

magicalunicor commented Oct 16, 2023 •
edited

Hi! I'm on it :)
edit: I will create a class so that the JSON export makes sense

magicalunicor added a commit to magicalunicor/Tinyinfo that referenced this issue Oct 16, 2023
@magicalunicor
Added button to export as JSON :)
234d894 
I also modified two small things: both the button for the plain text and json will call the same function (DRY).
XML I don't think it makes sense, but still.
This solves partially issue Lion-Craft#60
@magicalunicor magicalunicor mentioned this issue Oct 16, 2023
Merged
@Lion-Craft Lion-Craft mentioned this issue Oct 23, 2023
Closed
@Lion-Craft Lion-Craft added this to the Version 3.0 milestone Nov 9, 2023
@Lion-Craft
Copy link
Owner Author

Redoing the JSON export the ape way now due to the new nvapi data

This was referenced Nov 9, 2023
Merged
Closed
@Lion-Craft
Copy link
Owner Author

JSON export is fully working now

This was referenced Nov 10, 2023
Merged
Merged
Lion-Craft added a commit that referenced this issue Nov 10, 2023
@Lion-Craft
Merge pull request #125 from Lion-Craft/staging
614b1ff 
#60 Added XML Export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging a pull request may close this issue.

#60 Added XML Export Lion-Craft/Tinyinfo
2 participants
@Lion-Craft @magicalunicor