Move @types/express to devDeps & type-check the .d.ts file #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three little commits, three little things :
npm test
was failing on my machine because it's used intest.js
without being mentioned inpackage.json
.@types/express
from deps to devDeps, as discussed in @types/express should be moved under devDependencies #4. Works fine if the client has@types/express
in it's own dependencies, which should be the case. Otherwise, that user isn't working in strict mode and having or not@types/express
won't make any difference.