-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
classBasedClassifierDeducerFor doesn't work with bundlers/minifiers #143
Labels
bug
Something isn't working
Comments
The easiest way to fix this is probably to add a field |
See PR #146 |
dslmeinte
added a commit
that referenced
this issue
Mar 25, 2024
dslmeinte
added a commit
that referenced
this issue
Mar 27, 2024
dslmeinte
added a commit
that referenced
this issue
Mar 27, 2024
dslmeinte
added a commit
that referenced
this issue
Mar 27, 2024
dslmeinte
added a commit
that referenced
this issue
Mar 28, 2024
Fixed by PR #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
classBasedClassifierDeducerFor
uses theconstructor.name
property that bundlers and minifiers will potentially change. I managed to break it just by importing an unrelated "Property" function; the bundler decided to rename Lionweb's Property class to Property2, thus making it impossible to deserialize any language.In Tylasu we solved this with an optional property one can add to classes to fix their name, and a decorator that makes setting the property easier. Something like:
The text was updated successfully, but these errors were encountered: