Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FeaturesContainer to Classifier #105

Closed
enikao opened this issue Mar 31, 2023 · 4 comments
Closed

Rename FeaturesContainer to Classifier #105

enikao opened this issue Mar 31, 2023 · 4 comments

Comments

@enikao
Copy link
Contributor

enikao commented Mar 31, 2023

Name is weird, because it describes the function of the element. Other M3 elements have names to describe their nature.

@enikao enikao added the M3 label Mar 31, 2023
@enikao
Copy link
Contributor Author

enikao commented Mar 31, 2023

Postponed until #104 is decided (as we might not need FeaturesContainer if we don't have interfaces).

Consider future enhancement about Annotations (#13)

@enikao enikao added the postponed Postponed for later discussion label May 6, 2023
@enikao
Copy link
Contributor Author

enikao commented May 6, 2023

Postponed together with #104

@joswarmer
Copy link
Contributor

Done on Juli 7 2023

@enikao enikao removed the postponed Postponed for later discussion label Jul 10, 2023
@enikao
Copy link
Contributor Author

enikao commented Jul 10, 2023

On 2023-07-07, we decided to rename FeaturesContainer to Classifier.

Rationale: Name is weird, because it describes the function of the element. Other M3 elements have names to describe their nature.

Classifier is not ideal either, as the symmetric specialization of this would be Class rather than Concept. However, "classification" is a term in its own, and aptly fits this entity.
We discussed variants of Type (e.g. ObjectType) for name, symmetric to DataType. If we used Type instead of LanguageEntity (#147), there would be a nice symmetry. However, type is very easy to mix up with typesystem concerns, which is often very confusing.

@enikao enikao changed the title Rename FeaturesContainer? Rename FeaturesContainer to Classifier Jul 10, 2023
enikao pushed a commit that referenced this issue Jul 10, 2023
@enikao enikao closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants