Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version property to M3 Metamodel #92

Closed
enikao opened this issue Mar 6, 2023 · 8 comments
Closed

Add version property to M3 Metamodel #92

enikao opened this issue Mar 6, 2023 · 8 comments

Comments

@enikao
Copy link
Contributor

enikao commented Mar 6, 2023

Based on discussion on 2023-03-03 and #7, we add the property version: integer to Metamodel.

@ftomassetti
Copy link
Contributor

Are there constraints on this value? Should it be >= 1?

@enikao
Copy link
Contributor Author

enikao commented Mar 24, 2023

I'd say so --> Will update docs

@enikao
Copy link
Contributor Author

enikao commented Mar 24, 2023

Is version an integer or string?

See also LionWeb-io/lionweb-java#46 (comment)

From #99 (comment):

I think for M3 it makes sense to define version as integer, so we can apply language migrations in a well-defined way. If we made it a string and encounter versions 1-trial and 1-beta, we cannot establish a clear migration path.

Regarding serialization:

Because we use JSON string type everywhere (and never JSON number type). Maybe someone wants to have a version with more than 53 digits? (-;

@ftomassetti
Copy link
Contributor

I think we need a decision about integer vs string

@enikao
Copy link
Contributor Author

enikao commented Apr 7, 2023

Do we want to discuss this in the meeting or just here?

@ftomassetti
Copy link
Contributor

I would say that a poll would be enough

@enikao
Copy link
Contributor Author

enikao commented Apr 20, 2023

I think we first need to decide on #130 before we can decide this.

@enikao
Copy link
Contributor Author

enikao commented May 6, 2023

Decision: version is a string
See #130 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants