Connect via pbrouter #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now talk to a logger behind a PakBus router - possible fix for issue 19
Also fixed issue 14: argument output: invalid FileType('w', 0) value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed so that you can now talk to a logger sitting behind a PakBus router. Tested against a CR1000 behind an NL201 router and an RF401 radio link. You must set --dest to the node address of the logger and --dest_addr to the node address of the pbrouter.
Still works fine with devices not behind a router - tested on a CR1000 connected directly to ethernet.
May fix #19, but not tested with a CR1000 acting as the router.
Also fixes #14 (getdata error message on argument "output") - the "open" command no longer works unbuffered on text files, so now opens the file using the default buffering.