Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set chromedriver version based on chrome version #129

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

cboyden
Copy link

@cboyden cboyden commented Aug 18, 2020

Since Chrome version 73, Chromedriver versions are synchronized with Chrome versions; a major release of Chromedriver only works with the matching major release of Chrome. The behat.sh script can choose the correct version automatically, but we can still allow pinning to specific versions of Chromedriver if needed.

Copy link
Owner

@LionsAd LionsAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTBM - looks good to me

@LionsAd LionsAd merged commit 4b273d9 into LionsAd:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants