Update plugin system by using the PluginBase from D8 #5
Conversation
…version of service_container. Remove the test related to the old BasePlugin. Replaced the method getType() by getPluginId().
|
PHP Fatal error: Class 'Drupal\Component\Plugin\PluginBase' not found in /home/travis/build/LionsAd/render_cache/src/RenderCache/Controller/AbstractBaseController.php on line 16 But the module service_container is a dependency. |
|
Yeah, we first need to update service_container-7.x-1.x-dev on d.org, before this will work. |
|
Will do so today, the PR looks great! |
|
But I don't understand why the tests are failing. It should work if service_container (dev or not, because PluginBase is in there) is a dependency. What is wrong ? |
|
service_container still calls the plugins with different arguments. |
|
Oh and for unit tests we need the same fix of having tests/composer.json depend on service_container: 'dev-7.x-1.x'. |
|
See tests/composer.json in OpenLayers. |
|
Well done 👍 seems that tests are ok now... let's wait the end. |
| "Drupal\\Component\\": "lib/" | ||
| "Drupal\\Component\\": "lib/", | ||
| "Drupal": "../lib/", | ||
| "Psr": "../lib/" |
There was a problem hiding this comment.
Can we revert those changes, please?
This reverts commit 91e21e3.
|
Just updated code to have it working with latest version of Service Container, hopefully the syntax won't change from now. |
|
1 timeout, 7 greens on 8 tests. |
|
Thanks, @drupol |
Update plugin system by using the PluginBase from D8
Remove the tests related to the old BasePlugin.
Replaced the method getType() by getPluginId().