Add a current user service #14
Conversation
| drupal_save_session(FALSE); | ||
| $GLOBALS['user'] = $admin_user; | ||
|
|
||
| $this->assertEqual(array_keys($admin_user->roles), $account->getRoles()); |
There was a problem hiding this comment.
Need to re-get $account from the container before that.
There was a problem hiding this comment.
Or better yet check that old $account did not change.
|
These failures are a consequence of a drupal_ti bug fixed in the add-behat-integration branch. I will pull it tomorrow morning. |
|
drupal_ti is fixed. |
| parent::setUp($modules); | ||
|
|
||
| \ServiceContainer::init(); | ||
| $this->container = \Drupal::getContainer(); |
There was a problem hiding this comment.
nit - Need to document the $this->container variable.
There was a problem hiding this comment.
Fixed, it almost seems to be that we collect a bunch of issues before we can merge them.
1 similar comment
| // @see _drupal_session_write() | ||
| $sid = session_id(); | ||
| if ($this->variable->get('https', FALSE)) { | ||
| $insecure_session_name = substr(session_name(), 1); |
There was a problem hiding this comment.
This is the wrong way round and gets the insecure session ID from the secure one.
I would prefer if we did throw a BadMethodCallException for now.
It might be that mixed mode SSL is even removed from core.
There was a problem hiding this comment.
This should not used by application code anyway. Agreed.
|
Last issue to fix, then RTBM. |
| * {@inheritdoc} | ||
| */ | ||
| public function getPreferredAdminLangcode($fallback_to_default = TRUE) { | ||
| throw new \Exception(sprintf('%s is not implemented', __FUNCTION__)); |
|
This needs a rebase, then RTBM. |
…ly test the right one
|
Beside the rebase I decided to use the new base class in the tests. |
A lot of code is getting the current user to get the uid or simple do some user_access().
Let's implement the 'current_user' service from D8