Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the ContainerInterface::get contract for NULL_ON_INVALID_REFERENCE and not return FALSE #16

Merged
merged 10 commits into from
Dec 3, 2014
Merged

Respect the ContainerInterface::get contract for NULL_ON_INVALID_REFERENCE and not return FALSE #16

merged 10 commits into from
Dec 3, 2014

Conversation

dawehner
Copy link
Collaborator

@dawehner dawehner commented Dec 3, 2014

Based upon #11

Fixes #15

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d73025f on dawehner:container-get-null into e950cc9 on LionsAd:7.x-1.x.

@dawehner
Fix the behaviour for not existing services with NULL_ON_REFERENCE.
c521068 
* Don't look up the service twice, but also throw an exception if the second call
  specifies EXCEPTION_ON_REFERENCE.
@dawehner
Copy link
Collaborator Author

dawehner commented Dec 3, 2014

Found another case:

  • First call with NULL_ON_INVALID_REFERENCE
  • Second call: EXCEPTION_ON_INVALID_REFERENCE

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c521068 on dawehner:container-get-null into e950cc9 on LionsAd:7.x-1.x.

@LionsAd
Copy link
Owner

LionsAd commented Dec 3, 2014

Nice one!

@LionsAd LionsAd mentioned this pull request Dec 3, 2014
Merged
@LionsAd LionsAd added RTBM and removed Needs review labels Dec 3, 2014
@LionsAd
Copy link
Owner

LionsAd commented Dec 3, 2014

RTBM

LionsAd added a commit that referenced this pull request Dec 3, 2014
@LionsAd
Merge pull request #16 from dawehner/container-get-null
6e2370f 
Respect the ContainerInterface::get contract for NULL_ON_INVALID_REFERENCE and not return FALSE
@LionsAd LionsAd merged commit 6e2370f into LionsAd:7.x-1.x Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RTBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix return value of ->get() to be NULL when asking for NULL on invalid instead of FALSE
3 participants
@dawehner @coveralls @LionsAd