Issue #2467477 by Pol: Add check for PHP 5.3.10

[drupol]

This module needs php 5.3.10 to work, so let's add a php restriction in the info file.

[dawehner]

Mh, given that we want to keep the service container compatible with Drupal core 8.0., if possible, we should rather go with PHP 5.4

@Polzme Which part of the code requires 5.5?

[drupol]

I'm unable to test with PHP 5.4 yet unfortunately.

[coveralls]

Coverage remained the same at 100.0% when pulling 697380e on Polzme:Add-PHP-restriction-in-info-file into 1d74456 on LionsAd:7.x-1.x.

[coveralls]

Coverage remained the same at 100.0% when pulling 66a400d on Polzme:Add-PHP-restriction-in-info-file into 1d74456 on LionsAd:7.x-1.x.

[LionsAd]

For which parts do we require PHP 5.4 atm.?

I am okay to temporarily require PHP 5.4, but in the long run I still want to support PHP 5.3 using https://igor.io/2013/07/26/evolving-syntax.html to automatically convert PHP 5.4 back to 5.3.

[LionsAd]

We will need a test to show which core part we are using requires PHP 5.4, so we have that documented.

We also quite urgently before releasing a service_container beta should update to a newer beta of Drupal 8 Core for all code we currently have copied.

[drupol]

I'm unfortunately unable to test with PHP 5.3.

[drupol]

According to symfony-cmf/media-bundle#76 (comment), 5.3.10 is the minimum PHP version that we can use.
Updating the info file accordingly.

[LionsAd]

Lets get this in, 5.3.10 sounds great!

[drupol]

Yeah ! :)

-φol d.-

On Mon, Jun 8, 2015 at 4:47 PM, Fabian Franz notifications@github.com
wrote:

Lets get this in, 5.3.10 sounds great!

—
Reply to this email directly or view it on GitHub
#21 (comment)
.