Issue #2504025 by Fabianx, Pol: Add static container factory method for plugins (D8 style) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $plugin_class = static::getPluginClass($plugin_id, $plugin_definition); | ||
|
|
||
| // If the plugin provides a factory method, pass the container to it. | ||
| if (is_subclass_of($plugin_class, 'Drupal\service_container\Plugin\ContainerAwarePluginManager')) { |
There was a problem hiding this comment.
This needs to be the Interface that I outlined, not our own.
We are okay to add that interface, too.
|
Investigating... There were 2 errors:
|
| * @inheritdoc | ||
| */ | ||
| public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) { | ||
| return 'Hello World!'; |
There was a problem hiding this comment.
No, that is wrong.
This needs to be:
return new static($configuration, $plugin_id, $plugin_definition, 'Hello World');
then add a __construct here, that populates $this->data and add a getData() method.
There was a problem hiding this comment.
Actually, I wrote that because I didn't know how to test it correctly.
|
RTBM |
|
Just waiting for tests and coverage report. |
LionsAd
changed the title
LionsAd
changed the title
LionsAd
added a commit
that referenced
this pull request
Jun 24, 2015
…ntainerAwarePluginManager Issue #2504025 by Fabianx, Pol: Add static container factory method for plugins (D8 style)
drupol
deleted the
Update-createInstance-method-of-ContainerAwarePluginManager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.