-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2527162: Cannot call global functions that take a method by reference (follow-up) #83
Conversation
The best of both worlds ;-) |
foreach($args as $key => &$arg) { | ||
$args_reference[$key] = &$arg; | ||
} | ||
call_user_func_array($method, $args_reference); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return ...
everywhere, that is why travis failed.
foreach($args as $key => &$arg){ | ||
$args_reference[$key] = &$arg; | ||
switch(count($args)) { | ||
case 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 0 case is not handled.
return $method();
CNW |
…ference (follow-up)
$method($args[0], $args[1], $args[2]); | ||
break; | ||
case 4: | ||
$method($args[0], $args[1], $args[2], $args[3], $args[4]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUG - Travis found, needs to be only to $args[3] here.
Issue #2527162: Cannot call global functions that take a method by reference (follow-up)
No description provided.