-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Drupal 8 container via extension #97
Conversation
- Aliases syntax - Factory syntax
Ok, so, now at this point, what should we do ? |
We need to fix the tests :) |
@@ -366,7 +366,7 @@ public function set($id, $service, $scope = ContainerInterface::SCOPE_CONTAINER) | |||
* {@inheritdoc} | |||
*/ | |||
public function has($id) { | |||
return isset($this->services[$id]) || isset($this->serviceDefinitions[$id]); | |||
return isset($this->aliases[$id]) || isset($this->services[$id]) || isset($this->serviceDefinitions[$id]) || array_key_exists($id, $this->services); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to go upstream.
} | ||
|
||
- $code[$key] = [$method, $arguments]; | ||
+ $code[$key] = array($method, $arguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot go upstream - unless with very muck luck.
'value' => $private_service, | ||
'id' => 'private__' . $private_hash, | ||
), | ||
'%some_config%' | ||
), | ||
); | ||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented out code found!
Waiting for tests to finish, then merge. |
Waiting for scrutinizer |
Use Drupal 8 container via extension
This fixes #89.
BC breaks:
Before:
After: