Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when running testJavaScriptCoreMiniDOM #12

Closed
mrueger42 opened this issue Feb 15, 2017 · 5 comments
Closed

Crashes when running testJavaScriptCoreMiniDOM #12

mrueger42 opened this issue Feb 15, 2017 · 5 comments
Labels

Comments

@mrueger42
Copy link

Device: Nexus 5X with 7.1.1
Emulator: Nexus 5 API 24

A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 19475 (roidJUnitRunner)

Build fingerprint: 'google/bullhead/bullhead:7.1.1/N4F26O/3582057:user/release-keys'
02-15 15:10:32.694 19491-19491/? A/DEBUG: Revision: 'rev_1.0'
02-15 15:10:32.694 19491-19491/? A/DEBUG: ABI: 'arm64'

@ericwlange
Copy link
Member

Thanks for registering the issue. I am aware of this bug. It should work fine if you run that test alone, but it will crash if you run it in sequence with the other JSC tests.

There is some disagreement between how I've implemented garbage collection and how JavaScriptCore expects it to happen. This is occurring because the collector is running and clearing away unreferenced JSValueRefs, as the test code does not JSValueRetain the references. (Note, these tests are not written by me -- these are Apple's JSC tests, so I treat them as the gold standard for expected behavior). So there is some lifecycle assumption apparent in JSC that I haven't figured out yet.

I have slated this for fix in 0.3.0, which is the first release to actually use the JSC code (as it is required by React Native). At the moment, the JSC functionality is experimental.

@ericwlange ericwlange added this to TODO in Release 0.2.2 Feb 15, 2017
@mrueger42
Copy link
Author

There is a comment here
https://github.com/hszhsh/JavaScriptCore
relating to GC, not sure if that may be of any help
"I'm using WTF's RunLoop for GC timers on Android, so you need to call RunLoop::iterate() in your app's runloop on js thread."

@ericwlange
Copy link
Member

Well, I'm not actually using JSC at all. LiquidCore runs on V8 -- I am shimming the JSC API and translating it to V8. The tests are to ensure that it complies with what JSC applications expect. I've cracked all other assumptions. This is the one sinister bug that remains!

@ericwlange ericwlange added the bug label Feb 15, 2017
@ericwlange ericwlange moved this from TODO to Backlog in Release 0.2.2 Mar 15, 2017
ericwlange added a commit that referenced this issue Mar 25, 2017
- Fixed issue #12
- Make sure all HashMap and SparseArray accesses are thread safe
- Removed constants and replaced with #defines for better readability
@ericwlange
Copy link
Member

@ericwlange ericwlange moved this from Backlog to Completed in Release 0.2.2 Mar 25, 2017
@ericwlange
Copy link
Member

This is fixed in Release 0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Release 0.2.2
Completed
Development

No branches or pull requests

2 participants