Can't run a node Process after invoking raw V8
#3
Projects
Comments
ericwlange
added a commit
that referenced
this issue
Dec 7, 2016
- Java side handled prototypes incorrectly, test was also incorrect -- fixed - Added a default constructor for NodeInstance() in an attempt to find a fix for issue [#3], doesn't fix the problem yet - Removed commented out code - Moved prototype functions back from JSFunction to JSObject where they belong
ericwlange
added a commit
that referenced
this issue
Dec 7, 2016
Replaced usage of `v8::Lock` with `std::recursive_mutex`. Once a v8 lock is used, v8 requires it to be used everywhere, even in a separate isolate. Since node.js uses a single thread, it does not implement locking. So if a lock is introduced, node will crash. We get the same value from `std::recursive_mutex` so we use that instead. Removed hack call of `NodeInstance init` as it has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Node requires some flags to be set prior to calling
V8::Initialize(). If you start by running a node process and then subsequently create some contexts using raw v8, everything works fine. If you swap the order, the app will crash on node initialization.The text was updated successfully, but these errors were encountered: