Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to build the library for node 10 instead of node 8.9.3? #88

Closed
stlpedro opened this issue Feb 27, 2019 · 4 comments
Closed
Labels
0.7.0 android Affects Android ios Affects iOS
Projects

Comments

@stlpedro
Copy link

Hi there,

Thank you so much for this great library. I wanted to know if it is possible to build it against nodejs 10.15.1 instead of nodejs 8.9.3.

Please let me know.

-Pedro

@ericwlange
Copy link
Member

Yes, but it will take some work. It is not simple to do. It is on my backlog to upgrade to v10.x. Do you mind me asking, what features are in v10 that you are looking for?

@stlpedro
Copy link
Author

stlpedro commented Mar 1, 2019 via email

@ericwlange
Copy link
Member

ericwlange commented Mar 2, 2019

What do you get from process.setUncaughtExceptionCaptureCallback that you don't get from process.on('uncaughtException', callback)? Just curious, because I've always used that.

What kinds of crashes are you getting? Is it Android or iOS? I am surprised it possible to crash without getting anything in the logs. There will be a stack trace in Dalvik (if you are on Android), even if it is cryptic. Is it actually "crashing" (as in you get a page fault or something) or is the process just exiting, albeit unexpectedly?

@ericwlange ericwlange added android Affects Android ios Affects iOS labels Jun 3, 2019
ericwlange added a commit that referenced this issue Oct 13, 2019
- Upgraded to node v10.15.3 from v8.9.3 (#88)
- Fixed massive memory leak on iOS (#129)
@ericwlange ericwlange added this to In progress in 0.7.0 Oct 16, 2019
@ericwlange ericwlange moved this from In progress to Done in 0.7.0 Oct 16, 2019
@ericwlange
Copy link
Member

0.7.x now uses 10.15.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7.0 android Affects Android ios Affects iOS
Projects
0.7.0
  
Done
Development

No branches or pull requests

2 participants