This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
lisk_snapshot.sh - Bugfix #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabello
reviewed
Feb 19, 2017
| @@ -163,7 +163,7 @@ dropdb --if-exists "$TARGET_DB_NAME" &> /dev/null | |||
|
|
|||
| echo -e "\n$(now) Deleting snapshots older then $DAYS_TO_KEEP day(s) in $BACKUP_LOCATION" | |||
| mkdir -p "$BACKUP_LOCATION" &> /dev/null | |||
| find "$BACKUP_LOCATION" -name "${SOURCE_DB_NAME}*.gz" -mtime +"$DAYS_TO_KEEP" -exec rm {} \; | |||
| find "$BACKUP_LOCATION" -name "${SOURCE_DB_NAME}*.gz" -mtime +"$(( DAYS_TO_KEEP - 1 ))" -exec rm {} \; | |||
There was a problem hiding this comment.
What about the original implementation doesnt work?
There was a problem hiding this comment.
keep 1 day over
There was a problem hiding this comment.
days to keep =2 should result in keeping last 48 hours of files
There was a problem hiding this comment.
If i say days to keep 7. Mtime +7 would keep 7 days and only delete things older than that, ie: 8 days.
There was a problem hiding this comment.
evrything else look like working perfectly in the last 3 days
There was a problem hiding this comment.
ok, i dont have time to test this now but i will do so later this week.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAYS_TO_KEEP cleanup command not working as expected