Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update state reader to use snapshot #6

Closed
Tracked by #26
shuse2 opened this issue May 5, 2022 · 0 comments · Fixed by #72
Closed
Tracked by #26

Update state reader to use snapshot #6

shuse2 opened this issue May 5, 2022 · 0 comments · Fixed by #72
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented May 5, 2022

Description

in lisk-sdk use-case, state execution only happens once in batch, so the transactional operation is not critical.
However, if execution and read from another process happens at the same time, it might return in consistent data.

Therefore, when creating StateReader or StateReadWriter, it should create rocksdb snapshot and use that for reading data

Acceptance criteria

  • Add test where read and write happen simultaneously
  • All other test should pass
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants