Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Resolve pending TODOs for DEX Core v.1.0.0 #249

Closed
Tracked by #61
emiliolisk opened this issue Mar 28, 2023 · 0 comments · Fixed by #252
Closed
Tracked by #61

Resolve pending TODOs for DEX Core v.1.0.0 #249

emiliolisk opened this issue Mar 28, 2023 · 0 comments · Fixed by #252
Milestone

Comments

@emiliolisk
Copy link
Contributor

emiliolisk commented Mar 28, 2023

Description

This task will resolve the pending TODOs in the codebase: https://github.com/LiskHQ/lisk-dex-core/search?q=todo&type=code.

  • Resolve all pending TODOs.
    • Timestamp checks on verify blocks of the following DEX commands:
      • addLiquidity
      • createPool
      • createPosition
      • removeLiquidity
      • swapExactIn
      • swapExactOut
      • swapWithPriceLimit
    • Add FeeMethod to DEX Commands
    • Replace legacy token transfer function for fees transferToProtocolFeeAccount with FeeMethod.payFee
    • Replace legacy token transfer function for fees transferToValidatorLSKPool with FeeMethod.payFee
    • Fix swapWithin on DEX swapFunctions.ts: use a valid totalIncentives value instead of 0.
  • Add tests and updated existing ones.
  • Update est config (we were using a deprecated format)
  • Update .gitignore.

Acceptance Criteria

  • All pending TODOs are resolved.
  • Unit tests were added and updated in the test/unit/modules/dex folder.
  • All tests are passing.
@emiliolisk emiliolisk self-assigned this Mar 28, 2023
@emiliolisk emiliolisk linked a pull request Apr 4, 2023 that will close this issue
@Naureen1lightcurve Naureen1lightcurve added this to the Sprint 23 milestone Apr 12, 2023
@Naureen1lightcurve Naureen1lightcurve changed the title Resolve pending TODOs Resolve pending TODOs for DEX Core v.1.0.0 Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants