Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Resolve pending TODOs #252

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Resolve pending TODOs #252

merged 4 commits into from
Apr 10, 2023

Conversation

emiliolisk
Copy link
Contributor

@emiliolisk emiliolisk commented Apr 4, 2023 •
edited
Loading

What was the problem?

This PR resolves #249 .

How was it solved?

  • Resolved all pending TODOs.
    • Timestamp checks on verify blocks of the following DEX commands:
      • addLiquidity
      • createPool
      • createPosition
      • removeLiquidity
      • swapExactIn
      • swapExactOut
      • swapWithPriceLimit
    • Add FeeMethod to DEX Commands
    • Replace legacy token transfer function for fees transferToProtocolFeeAccount with FeeMethod.payFee
    • Replace legacy token transfer function for fees transferToValidatorLSKPool with FeeMethod.payFee
    • Fix swapWithin on DEX swapFunctions.ts: use a valid totalIncentives value instead of 0.
  • Added tests and updated existing ones.
  • Updated Jest config (we were using a deprecated format)
  • Updated .gitignore

How was it tested?

  • Unit tests were added and updated in the test/unit/modules/dex folder.
  • All tests are passing.

@emiliolisk emiliolisk self-assigned this Apr 4, 2023
@emiliolisk emiliolisk linked an issue Apr 4, 2023 that may be closed by this pull request
Resolve pending TODOs for DEX Core v.1.0.0 #249
Closed
@Naureen1lightcurve Naureen1lightcurve added this to the Sprint 23 milestone Apr 5, 2023
@Daniel-Lightcurve
Copy link
Contributor

All looks fine for me.

Irfan-Personal
Irfan-Personal approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@Irfan-Personal Irfan-Personal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@emiliolisk emiliolisk merged commit e9a47b8 into feature/prepare-for-alpha Apr 10, 2023
@Naureen1lightcurve Naureen1lightcurve removed this from the Sprint 23 milestone Apr 12, 2023
@emiliolisk emiliolisk deleted the 249-resolve-todos branch July 28, 2023 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Irfan-Personal Irfan-Personal Irfan-Personal approved these changes

@Daniel-Lightcurve Daniel-Lightcurve Daniel-Lightcurve approved these changes

Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve pending TODOs for DEX Core v.1.0.0
4 participants
@emiliolisk @Daniel-Lightcurve @Irfan-Personal @Naureen1lightcurve