Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement tests for DEX Module LP command: createPool #270

Closed
emiliolisk opened this issue Jun 22, 2023 · 1 comment
Closed

Implement tests for DEX Module LP command: createPool #270

emiliolisk opened this issue Jun 22, 2023 · 1 comment

Comments

@emiliolisk
Copy link
Contributor

emiliolisk commented Jun 22, 2023

Description

createPool was tested with the following scenarios and expectations as mentioned below:

Scenario Expectation
Should be successful when all the parameters are correct Calls token methods and emits poolCreated, positionCreated events.
Should fail when tokenID0 and tokenID1 are not sorted lexicographically Exception is thrown.
Should fail when amount0Desired or amount1Desired are zero Exception is thrown.
Should fail when tickLower and tickUpper do not meet requirements Exception is thrown.
Should fail when header.timestamp > maxTimestampValid Exception is thrown.

Acceptance Criteria

  • Existing and new unit tests are passing
@emiliolisk emiliolisk self-assigned this Jun 22, 2023
@emiliolisk emiliolisk changed the title Implement tests for DEX Module internal functions Implement tests for DEX Module LP command: createPool Jun 22, 2023
@Naureen1lightcurve
Copy link
Contributor

This issue #270 is already resolved and the last modification is in this commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants