Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement tests for DEX Module LP command: removeLiquidity #277

Closed
emiliolisk opened this issue Jun 22, 2023 · 1 comment
Closed

Implement tests for DEX Module LP command: removeLiquidity #277

emiliolisk opened this issue Jun 22, 2023 · 1 comment

Comments

@emiliolisk
Copy link
Contributor

emiliolisk commented Jun 22, 2023

Description

removeLiquidity was tested with the following scenarios and expectations as mentioned below:

Scenario Expectation
Should be successful when all the parameters are correct Calls token methods and emits removeLiquidity event.
Should not be successful when current timestamp is over maxTimestampValid Exception is thrown.
Should terminate and throw error if positionsStore doesn't have position with the specified positionID Exception is thrown.
Should terminate due to liquidityToRemove > totalLiquidity Exception is thrown.
Should terminate and throw error as amount1Min > amount1 Exception is thrown.
Should terminate and throw error as amount0Min > amount0 Exception is thrown.

Acceptance Criteria

  • Existing and new unit tests are passing
@Naureen1lightcurve
Copy link
Contributor

This issue #277 is already resolved and the last modification is in this commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants