Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement Q96 number format - Closes #20 #35

Merged
merged 13 commits into from
Sep 12, 2022

Conversation

10dimensions
Copy link
Contributor

@10dimensions 10dimensions commented May 18, 2022

What was the problem?

This PR resolves #20

How was it solved?

Create module for Q96 Number System Computation

How was it tested?

  • Implementation was unit tested

@emiliolisk
Copy link
Contributor

This requires mathematical validation from external teams as well.

@emiliolisk emiliolisk removed this from the Sprint 3 milestone Jun 21, 2022
src/app/modules/dex/utils/q96.ts Outdated Show resolved Hide resolved
src/app/modules/dex/utils/q96.ts Outdated Show resolved Hide resolved
src/app/modules/dex/utils/q96.ts Outdated Show resolved Hide resolved
src/app/modules/dex/utils/q96.ts Outdated Show resolved Hide resolved
test/unit/modules/dex/q96.spec.ts Show resolved Hide resolved
test/unit/modules/dex/q96.spec.ts Show resolved Hide resolved
test/unit/modules/dex/q96.spec.ts Outdated Show resolved Hide resolved
src/app/modules/dex/utils/q96.ts Outdated Show resolved Hide resolved
src/app/modules/dex/utils/q96.ts Outdated Show resolved Hide resolved
test/unit/modules/dex/q96.spec.ts Outdated Show resolved Hide resolved
Copy link

@sergeyshemyakov sergeyshemyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything is nice, good job!

@emiliolisk emiliolisk changed the title Q96 Number Format Implementation Implement Q96 number format - Closes #20 Sep 12, 2022
@emiliolisk emiliolisk self-assigned this Sep 12, 2022
@emiliolisk emiliolisk merged commit 21b705f into development Sep 12, 2022
Irfan-Personal pushed a commit that referenced this pull request Mar 1, 2023
Implement Q96 number format - Closes #20
@karmacoma karmacoma deleted the feature/q96-number-system branch January 20, 2024 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Q96 number format
5 participants