Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Upgrade to SDK v6 - Closes #51 #64

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Upgrade to SDK v6 - Closes #51 #64

merged 2 commits into from
Aug 19, 2022

Conversation

emiliolisk
Copy link
Contributor

@emiliolisk emiliolisk commented Aug 17, 2022 •
edited
Loading

What was the problem?

This PR resolves #51

How was it solved?

  • I have upgraded the codebase to SDK v6 to allow development to continue on that version.

How was it tested?

  • Lisk DEX Core runs without errors, i.e. ./bin/run start
  • Lisk DEX Core passes unit tests, i.e. npm run test

@emiliolisk emiliolisk self-assigned this Aug 17, 2022
@emiliolisk emiliolisk changed the title Upgrade to SDK v6 Upgrade to SDK v6 - Closes #51 Aug 18, 2022
ishantiw
ishantiw reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App is running on start and overall it looks good. Some comments. Also, I will suggest to check Lisk Core for their usage of SDKV6 usage.

config/default/config.json Outdated Show resolved Hide resolved
config/default/config.json Outdated Show resolved Hide resolved
config/default/config.json Outdated Show resolved Hide resolved
config/default/config.json Outdated Show resolved Hide resolved
@emiliolisk emiliolisk merged commit e37ea3b into development Aug 19, 2022
@emiliolisk emiliolisk linked an issue Aug 31, 2022 that may be closed by this pull request
Implement core application using Lisk SDK v6.0.0 #4
Closed
1 task
Irfan-Personal pushed a commit that referenced this pull request Mar 1, 2023
@emiliolisk
Merge pull request #64 from LiskHQ/feature/upgrade-to-sdk-v6
1ef8341 
Upgrade to SDK v6 - Closes #51
@karmacoma karmacoma deleted the feature/upgrade-to-sdk-v6 branch January 20, 2024 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@Irfan-Personal Irfan-Personal Irfan-Personal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK v6 Migration Implement core application using Lisk SDK v6.0.0
3 participants
@emiliolisk @ishantiw @Irfan-Personal