Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Update ProtocolPeerInfo format #1070

Closed
shuse2 opened this issue Feb 2, 2019 · 0 comments
Closed

Update ProtocolPeerInfo format #1070

shuse2 opened this issue Feb 2, 2019 · 0 comments
Labels
*easy lisk-p2p
Projects
Version 2.1.0
Milestone
Introduce robust ...

Comments

@shuse2
Copy link
Contributor

shuse2 commented Feb 2, 2019

Expected behavior

Expect ProtocolPeerInfo type to match with the current protocol.
wsPort is returned as number.

Actual behavior

wsPort is expecting string.
@shuse2 shuse2 added this to To Do in Version 2.1.0 via automation Feb 2, 2019
@jondubois jondubois mentioned this issue Feb 5, 2019
Merged
Version 2.1.0 automation moved this from To Do to Done Feb 6, 2019
shuse2 added a commit that referenced this issue Feb 6, 2019
@shuse2
Merge pull request #1074 from LiskHQ/1070-compatibility_with_core_v1
1985f28 
Update ProtocolPeerInfo format - Closes #1070
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*easy lisk-p2p
Projects
No open projects
Version 2.1.0
  
Done
Milestone
Introduce robust peer selection and b...
Development

No branches or pull requests
2 participants
@jondubois @shuse2