Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Add peer management mechanism #894

Closed
shuse2 opened this issue Nov 22, 2018 · 0 comments
Closed

Add peer management mechanism #894

shuse2 opened this issue Nov 22, 2018 · 0 comments
Labels
lisk-p2p *medium
Projects
Version 2.1.0
Milestone
Introduce robust ...

Comments

@shuse2
Copy link
Contributor

shuse2 commented Nov 22, 2018 •
edited

Description

lisk-p2p needs a mechanism to manage all the known peers.

The main purpose of the pool is to hold the connected peer objects, but it should contain

  • get() using selection function similar to getGoodPeers
  • addConnection(connection) which takes raw connection and assign/create peer
  • addPeer(peer) which insert to pool
  • handle disconnect and remove from pool
  • disconnect all the peers
@shuse2 shuse2 added this to Open Issues in Version 2.1.0 via automation Nov 22, 2018
@shuse2 shuse2 moved this from Open Issues to Prioritised Issues in Version 2.1.0 Nov 28, 2018
@jondubois jondubois mentioned this issue Dec 11, 2018
Merged
shuse2 added a commit that referenced this issue Dec 14, 2018
@shuse2
Merge pull request #936 from LiskHQ/p2p_jon
42e978b 
Initialization start(), stop() and peer management - Addresses #894 and #895
@shuse2 shuse2 closed this as completed Dec 14, 2018
Version 2.1.0 automation moved this from Prioritised Issues to Closed Issues Dec 14, 2018
@shuse2 shuse2 pinned this issue Dec 14, 2018
@shuse2 shuse2 unpinned this issue Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lisk-p2p *medium
Projects
No open projects
Version 2.1.0
  
Done
Milestone
Introduce robust peer selection and b...
Development

No branches or pull requests
2 participants
@jondubois @shuse2