Remove the requirement for recipient_public_key property for vote transaction #1202

SargeKhan · 2019-03-28T10:34:28Z

The recipient_public_key was required for vote transaction in lisk-transactions, but it's not required by the protocol.

Removed the restriction, and the relevant tests.

Run the tests.

The PR resolves Vote transaction should not throw an error if recipientPublicKey is not preset #1201
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated

remove restriction for recipient_public_key for vote

c9eb711

SargeKhan added this to the Improve transaction processing efficiency milestone Mar 28, 2019

SargeKhan self-assigned this Mar 28, 2019

SargeKhan added the 👁️ pending review label Mar 28, 2019

shuse2 removed this from the Improve transaction processing efficiency milestone Mar 28, 2019

shuse2 approved these changes Mar 28, 2019

View reviewed changes

shuse2 assigned mitsuaki-u Mar 28, 2019

shuse2 added this to Open PRs in Version 2.1.0 via automation Mar 28, 2019

shuse2 requested a review from mitsuaki-u March 28, 2019 13:46

shuse2 unassigned mitsuaki-u Mar 28, 2019

mitsuaki-u approved these changes Mar 28, 2019

View reviewed changes

shuse2 added ✅ ready and removed 👁️ pending review labels Mar 28, 2019

shuse2 merged commit 262f5ff into release/2.1.0 Mar 28, 2019

Version 2.1.0 automation moved this from Open PRs to Closed PRs Mar 28, 2019

shuse2 deleted the 1201-remove_requirement_for_recipient_public_key branch March 28, 2019 13:47

Provide feedback