This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Add functions to create dapp deposits/withdrawals - Closes #145 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
changed the title
willclarktech
force-pushed
the
145-dapp_in_out_transfer_0.4.4
branch
from
edb9a1a
to
2608b00
Compare
Isabello
reviewed
Jul 19, 2017
| var secret = 'secret'; | ||
| var publicKey = '5d036a858ce89f844491762eb89e2bfbd50a4a0a0da658e4b2628b25b117ae09'; | ||
| var secondSecret = 'secondSecret'; | ||
| var outTransferTransaction = createOutTransfer(dappId, transactionId, recipientId, amount, secret, secondSecret); |
There was a problem hiding this comment.
Can this be abstracted into its own file? Will be easier to modify later if/when things change if these variables are declared in a single place.
There was a problem hiding this comment.
These tests will be restructured as part of #178 - are you happy if we do that then rather than now? (I agree it would be nice.)
diego-G
approved these changes
Jul 19, 2017
karmacoma
removed
📝 test
standards
♻️ refactoring
🌱 enhancement
*easy
📚 docs
🏠 chore
🐛bug
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #199 firstCloses #145