This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Simplify Jenkinsfile #388
Merged
Simplify Jenkinsfile #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove locking and milestone; use declarative pipeline syntax.
toschdev
previously approved these changes
Sep 26, 2017
Isabello
suggested changes
Sep 27, 2017
Jenkinsfile
Outdated
| milestone 1 | ||
| deleteDir() | ||
| currentBuild.result = 'SUCCESS' | ||
| } | ||
| } |
There was a problem hiding this comment.
Please re add the cleanup step so we do not run out of space keeping successful builds on disk.
Call deleteDir() after a sucessful build to preserve space.
Isabello
approved these changes
Sep 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove locking and milestone; use declarative pipeline syntax.