Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Migration-to-ES2015: Migrated liskApi.js #523

Closed

Conversation

Reshetnyak
Copy link

Purpose of pull request

Start migration to ES2015. It would made migration to TypeScript a bit easier.

Changes proposed in this pull request

  • added babelify step in browserify task to be able transpile ES2015 to ES5
  • changed liskApi.js as a start of migration
  • added npm scripts for easier development

@toschdev
Copy link
Contributor

Hello @Reshetnyak - it seems that you have put a lot of effort into these Pull Requests.
Maybe it would have saved you a lot of time to look at the 1.0.0 branch - the code is already migrated to newest JS standards.

@Reshetnyak
Copy link
Author

Hi @Tosch110 , Yap, my bad. I've missed it. Fill free to reject all of these PR's.
Maybe, you need some particular help? I'm not into crypto libraries, but know some Webpack, TypeScript, ES6+. I would like to be involved in it.

@toschdev
Copy link
Contributor

toschdev commented Jan 16, 2018

Hi @Reshetnyak yes, I thought so. I really appreciate the effort though.
Typescript is actually one of the more intense things to come next. Maybe you have seen the issue #417 . I think it would be quite valuable for us to have an example given. Maybe you could migrate a few example files to typescript, as we do not have the time for it right now. (probably going in depth of it somewhen in February 18)

Other than that all the Issues that are not assigned are open for anyone. It would be helpful when you are working on it to give a small comment on the issue that you are working on it. We cannot always rely on community members to actually finish PR's in a timely manner so if that would take a lot of time we might take it ourselves aswell.
Feel free to request more information on any issue if it is not described properly.

Other than that when you checkout the 1.0.0 branch, you will find contribution guidelines which should help to get started.

Hope this helps!

@toschdev toschdev closed this Jan 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants