This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Added sample flow setup - Discussion For #417 #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to CDN for lisk-js was broken, possibly because it was pointing to the development branch rather than master branch.
Fix CDN link in README.md
|
Closing due to wrong branch root |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sample setup regards to Implement strict type system #417.
It shows flow can easily setup, and partially included and gradually complete the improvement.
Set up flow for start using without affecting the current code too much.
What I did
libtosrc, and within src,flowtags are used (changed import path too)index.jsis also moved to inside ofsrcAlso,
npmpublish flow needs to be discussed.If we should keep the
libin repo, or build in CI and directly publish.