This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Create package and setup boilerplate for lisk-transaction-pool - Closes #870 #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
November 23, 2018 11:16
SargeKhan
changed the base branch from
development
to
transaction_improvement_experiment
shuse2
suggested changes
Nov 23, 2018
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "env": { | |||
| "mocha": true, | |||
There was a problem hiding this comment.
I don't think we need browsertest for transaction-pool.
It's a server-side only feature
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "video": false, | |||
| "pluginsFile": false, | |||
There was a problem hiding this comment.
we don't need cypress as we don't have browsertest
| "url": "https://github.com/LiskHQ/lisk-elements/issues" | ||
| }, | ||
| "engines": { | ||
| "node": ">=6.3 <=10", |
| "test:watch": "npm test -- --watch", | ||
| "test:watch:min": "npm run test:watch -- --reporter=min", | ||
| "test:node": "npm run build:check", | ||
| "serve:start": "http-server -p 11542 ./browsertest &", |
There was a problem hiding this comment.
we can delete all browser related stuff
| "chai": "4.1.2", | ||
| "cypress": "3.1.0", | ||
| "eslint": "5.5.0", | ||
| "eslint-config-airbnb-base": "13.1.0", |
There was a problem hiding this comment.
we can delete browser related stuff + eslint and babel
added 5 commits
November 23, 2018 11:57
shuse2
suggested changes
Nov 23, 2018
| rm -rf .nyc_output/ | ||
| rm -rf browsertest.build/ | ||
| rm -rf coverage/ | ||
| rm -rf dist-browser/ |
There was a problem hiding this comment.
you can remove unneeded folder delete commands here
shuse2
suggested changes
Nov 23, 2018
| "@types/node": "10.10.1", | ||
| "bip39": "^2.5.0", | ||
| "chai": "4.1.2", | ||
| "cypress": "3.1.0", |
| }, | ||
| "dependencies": {}, | ||
| "devDependencies": { | ||
| "@types/bip39": "^2.4.0", |
There was a problem hiding this comment.
bip39 would not be needed too
shuse2
approved these changes
Nov 23, 2018
mitsuaki-u
reviewed
Nov 23, 2018
| }, | ||
| "engines": { | ||
| "node": ">=8.10 <=10", | ||
| "npm": ">=3 <=6" |
There was a problem hiding this comment.
other packages list "npm":">=5"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new package for
@lisk/lisk-transaction-pool, add npm scripts for running application and for running testing. Furthermore, add the skeleton code for transaction pool.