This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Fix voters list on delegate page - Closes #502 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalTuleja
suggested changes
Apr 5, 2018
lib/api/accounts.js
Outdated
| return cb(null, account); | ||
| }); | ||
| account.voters = []; | ||
| return this.getVotersCall(account, 100, 0, cb); |
There was a problem hiding this comment.
We should avoid using literals as parameters. The literals above should be replaced with defined variables or constants. ex. const limit = 100 and reference to the limit in the function params.
MichalTuleja
approved these changes
Apr 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Voters list wasn't showing on delegate page
How did I fix it?
I've fixed the getVoters calling it recursively until all voters are returned. That was required as core api limits the response to 100 items.
I also added an issue suggesting we improve the UI for this list adding pagination.
How to test it?
Assuming you are using test data, access
delegate/3038510178697972178Land you should see the list with 2 votersReview checklist