Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Write unit tests for electron code #900

Closed
slaweet opened this issue Oct 20, 2017 · 0 comments
Closed

Write unit tests for electron code #900

slaweet opened this issue Oct 20, 2017 · 0 comments
Labels
*hard test
Projects
Version 1.3.0 Sprint Board 13-11-17

Comments

@slaweet
Copy link
Contributor

slaweet commented Oct 20, 2017

Expected behaviour

Electron wrapper code should be covered with unit tests. It might require some refactoring to make the code testable.

Actual behaviour

There is growing code with no unit tests:
https://github.com/LiskHQ/lisk-nano/tree/development/app/src
@slaweet slaweet self-assigned this Oct 26, 2017
@slaweet slaweet added this to Issues in Sprint Board 30-10-17 Oct 26, 2017
@slaweet slaweet added this to Issues in Version 1.3.0 via automation Nov 2, 2017
@slaweet slaweet added this to Issues in Sprint Board 06-11-17 via automation Nov 2, 2017
@slaweet slaweet removed this from Issues in Sprint Board 30-10-17 Nov 2, 2017
@slaweet slaweet assigned ginacontrino and unassigned slaweet Nov 6, 2017
@ginacontrino ginacontrino mentioned this issue Nov 8, 2017
Merged
3 tasks
@slaweet slaweet removed this from Issues in Sprint Board 06-11-17 Nov 13, 2017
@slaweet slaweet added this to Issues in Sprint Board 13-11-17 via automation Nov 13, 2017
@slaweet slaweet added *hard and removed *medium labels Nov 14, 2017
ginacontrino pushed a commit that referenced this issue Nov 15, 2017
Merge pull request #970 from LiskHQ/900-electron-tests
aa9dd5e 
Write unit tests for electron code - Closes #900
Version 1.3.0 automation moved this from Issues to Closed Issues Nov 15, 2017
Sprint Board 13-11-17 automation moved this from Issues to Closed Issues Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*hard test
Projects
No open projects
Sprint Board 13-11-17
  
Closed Issues
Version 1.3.0
  
Closed Issues
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slaweet @ginacontrino