Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Frameless window #393

Closed
wants to merge 3 commits into from
Closed

Frameless window #393

wants to merge 3 commits into from

Conversation

alepop
Copy link
Contributor

@alepop alepop commented Jun 12, 2017

Make app window more 馃拝

  • Add frameless window
  • Polish loading bar (I think now the best position is at the bottom of the window)

Before:
old
After:
frameless
loading

@slaweet
Copy link
Contributor

slaweet commented Jun 13, 2017

Thanks, @alepop, the frameless window looks really cool. 馃憤
Though, I noticed that pop-up toast notifications are not going all the way to the screen in this PR:
screen shot 2017-06-13 at 11 25 49
Before it looked like:
screen shot 2017-06-13 at 11 25 14

Also, did you check if there are no other side effects on Windows and Linux?

@alepop
Copy link
Contributor Author

alepop commented Jun 13, 2017

@slaweet ok, i will fix the pop-up. What about loading bar?
I can not test on Win or Linux 馃槥

Copy link

@Isabello Isabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On windows there is no head bar which means there are no drop down menus. Additionally, removing the header on windows makes text unselectable on windows and instead moves the whole window when you try to select the test

We need the header to be present on windows and for the behavior to be as it was for text selection

@alepop
Copy link
Contributor Author

alepop commented Jun 13, 2017

@Isabello sounds bad. Maybe set frameless window only for macOS? Need core team decision.

@slaweet
Copy link
Contributor

slaweet commented Jun 13, 2017

makes text unselectable on windows and instead moves the whole window when you try to select the text

This happens also on Mac OS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants