Checking sender address earlier #266.

LiskArchive · Sep 9, 2016 · 3c600c2 · 3c600c2
1 parent e48806f
commit 3c600c2
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/logic/transaction.js b/logic/transaction.js
@@ -283,6 +283,11 @@ Transaction.prototype.verify = function (trs, sender, requester, cb) {
 		return setImmediate(cb, 'Missing sender');
 	}
 
+	// Check sender address
+	if (String(trs.senderId).toUpperCase() !== String(sender.address).toUpperCase()) {
+		return setImmediate(cb, 'Invalid sender address');
+	}
+
 	// Check requester public key
 	if (trs.requesterPublicKey) {
 		if (sender.multisignatures.indexOf(trs.requesterPublicKey) < 0) {
@@ -384,11 +389,6 @@ Transaction.prototype.verify = function (trs, sender, requester, cb) {
 		}
 	}
 
-	// Check sender address
-	if (String(trs.senderId).toUpperCase() !== String(sender.address).toUpperCase()) {
-		return setImmediate(cb, 'Invalid sender');
-	}
-
 	// Calculate fee
 	var fee = __private.types[trs.type].calculateFee.call(this, trs, sender) || false;
 	if (!fee || trs.fee !== fee) {