Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add minimal client version parameter to config.json #244

Closed
Gr33nDrag0n69 opened this issue Aug 6, 2016 · 0 comments
Closed

Add minimal client version parameter to config.json #244

Gr33nDrag0n69 opened this issue Aug 6, 2016 · 0 comments
Assignees
@karmacoma
Labels
type: improvement
Milestone
Version 0.4.0 / 0...

Comments

@Gr33nDrag0n69
Copy link

A while ago, Isabella wrote this script using slasheks python wrapper.

https://raw.githubusercontent.com/Isabello/lisk-tools/development/banTool.sh

Since lisk client already have a built in way of banning some IPs and also have the client version informations inside the DB, it would be usefull (for forging nodes) to be able to ban lower version.

For example, on testnet behing able to block 3.1 or older afetr v0.3.2a is out.
@karmacoma karmacoma added this to the Mainchain Stabilisation milestone Sep 30, 2016
@karmacoma karmacoma self-assigned this Sep 30, 2016
@karmacoma karmacoma changed the title add minimal client version parameter to config.json Add minimal client version parameter to config.json Sep 30, 2016
karmacoma pushed a commit that referenced this issue Nov 15, 2016
Closes #244. Adding minimal client version parameter #244.
9e778ca 
Defined as semver ruling for flexible version number matching.

Applies to peer request and response headers.
karmacoma pushed a commit that referenced this issue Nov 18, 2016
Closes #244. Adding minimal client version parameter.
13edfca 
Defined as semver ruling for flexible version number matching.

Supports release candidate letter matching e.g. ~0.0.0a.

Applies to peer request and response headers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karmacoma karmacoma

Labels
type: improvement
Projects
None yet
Milestone
Version 0.4.0 / 0.5.0
Development

No branches or pull requests
2 participants
@karmacoma @Gr33nDrag0n69