Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove "eslint-disable" statements from on top of files #2447

Closed
yatki opened this issue Oct 8, 2018 · 0 comments · Fixed by #2547
Closed

Remove "eslint-disable" statements from on top of files #2447

yatki opened this issue Oct 8, 2018 · 0 comments · Fixed by #2547

Comments

@yatki
Copy link
Contributor

yatki commented Oct 8, 2018

Expected behavior

We shouldn't disable eslint rules generally and especially in the whole file. If it's really necessary, It is possible to disable certain rules for certain code blocks. See: #disabling-rules-with-inline-comments

We should refactor the codebase and implement more convenient solutions.

Actual behavior

We are disabling eslint rules on top test files. See: test/unit/modules/accounts.js#L1

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

1.3.0+

@yatki yatki changed the title Remove "eslint-disable mocha/no-skipped-tests" statements from on top of test files Remove "eslint-disable" statements from on top of test files Oct 8, 2018
@yatki yatki changed the title Remove "eslint-disable" statements from on top of test files Remove "eslint-disable" statements from on top of files Oct 8, 2018
@MaciejBaj MaciejBaj added this to the Version 1.4.0 milestone Oct 25, 2018
MaciejBaj added a commit that referenced this issue Nov 14, 2018
@shuse2 shuse2 reopened this Nov 17, 2018
@shuse2 shuse2 closed this as completed Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants