Mitigate against fork cause 2: Already confirmed transaction #259

Isabello · 2016-08-23T14:34:38Z

When fork cause 2 occurs, we do not delete the offending transaction. Instead the node continues to try and forge its block until it misses its slot entirely. The TX stays on the table and the node continues this behavior until it is cycled.

In order to mitigate this, the software needs to delete the offending TX from the table to allow proper forging to occur.

See attached log:

http://pastebin.com/npnEThjV

Checking for already confirmed transaction at end of Transaction.prototype.verify, instead of Transaction.prototype.process. Mitigates against fork cause 2, where transaction enters unconfirmed transaction list from another peer, before block has been processed and applied. Affects Blocks.prototype.generateBlock where each transaction is verified before inclusion. - Undoing offending transaction on fork cause 2. - Removing transaction from unconfirmed transaction list. - Refactoring code into separate prototype functions. - Reusing said functions in Blocks.prototype.processBlock.

- Returning error on already processed transaction. - Returning error on already confirmed transaction.

karmacoma added the type: bug label Aug 23, 2016

karmacoma added this to the Mainchain Stabilisation milestone Aug 31, 2016

karmacoma added the ready label Sep 6, 2016

karmacoma self-assigned this Sep 29, 2016

karmacoma changed the title ~~Fork Cause 2 - Mitigation~~ Undo any offending transactions upon fork cause 2 Sep 30, 2016

karmacoma added the medium label Sep 30, 2016

karmacoma added in progress and removed ready labels Oct 14, 2016

karmacoma added easy and removed medium labels Oct 22, 2016

karmacoma changed the title ~~Undo any offending transactions upon fork cause 2~~ Mitigate against fork cause 2: Already confirmed transaction Oct 22, 2016

karmacoma mentioned this issue Nov 6, 2016

Implement better transaction memory pool processing #306

Closed

karmacoma pushed a commit that referenced this issue Nov 9, 2016

Restoring sane API behaviour #259.

0940122

- Returning error on already processed transaction. - Returning error on already confirmed transaction.

karmacoma closed this as completed in 0ba271a Nov 18, 2016

karmacoma removed the in progress label Nov 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mitigate against fork cause 2: Already confirmed transaction #259

Mitigate against fork cause 2: Already confirmed transaction #259

Isabello commented Aug 23, 2016 •

edited by karmacoma

Loading

Mitigate against fork cause 2: Already confirmed transaction #259

Mitigate against fork cause 2: Already confirmed transaction #259

Comments

Isabello commented Aug 23, 2016 • edited by karmacoma Loading

Isabello commented Aug 23, 2016 •

edited by karmacoma

Loading