Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update peer selection (for connection) mechanism for selection of multiple peers #3346

Closed
shuse2 opened this issue Nov 22, 2018 · 1 comment
Closed

Update peer selection (for connection) mechanism for selection of multiple peers #3346

shuse2 opened this issue Nov 22, 2018 · 1 comment
Assignees
@diego-G
Labels
elements/P2P
Milestone
Sprint 2

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 22, 2018

Description

According to LIP0004, Update peer selection mechanism based on newPeers and triedPeers list and consider fixedlist and blacklist peers while selecting any peer.
Also, peer selection must take banned peers into account while selecting peers.
@ishantiw ishantiw changed the title Add peer selections for multiple peer Update peer selection mechanism for selection of multiple peers Feb 18, 2019
@shuse2 shuse2 transferred this issue from LiskArchive/lisk-elements Apr 15, 2019
@diego-G diego-G mentioned this issue Jun 4, 2019
Merged
@jondubois jondubois changed the title Update peer selection mechanism for selection of multiple peers Update peer selection (for connection) mechanism for selection of multiple peers Jul 15, 2019
@jondubois
Copy link
Contributor

This line of the LIP is particularly relevant to this issue: Select a peer from collection triedPeers with probability r and a peer from the collection newPeers with probability 1-r. The peer in each of the collections is selected uniformly at random.

@jondubois jondubois added this to the P2P resilience milestone Jul 17, 2019
@shuse2 shuse2 removed this from the P2P resilience milestone Jul 17, 2019
@sridharmeganathan sridharmeganathan added this to the Sprint 3 milestone Jul 24, 2019
@diego-G diego-G self-assigned this Jul 29, 2019
diego-G added a commit that referenced this issue Jul 30, 2019
@diego-G
Implement algorithm to select peers for connection #3346
ed28f70
@diego-G diego-G mentioned this issue Jul 30, 2019
Merged
5 tasks
jondubois added a commit that referenced this issue Aug 2, 2019
@jondubois
Merge pull request #4022 from LiskHQ/3346-update_peer_selection_multiple
e5887a8 
Update selection mechanism to connect to peers - Closes #3346
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
elements/P2P
Projects
None yet
Milestone
Sprint 2
Development

No branches or pull requests
4 participants
@jondubois @diego-G @shuse2 @sridharmeganathan