Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add queue counts to /api/transactions/unconfirmed #341

Closed
ghost opened this issue Dec 7, 2016 · 7 comments · Fixed by #370
Closed

Add queue counts to /api/transactions/unconfirmed #341

ghost opened this issue Dec 7, 2016 · 7 comments · Fixed by #370
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Dec 7, 2016

I've noticed that even when i've broadcasted roughly ~60 transactions, maximum amount returned in "count" field in /api/transactions/unconfirmed was limited to 25.

@jfernanz
Copy link

jfernanz commented Dec 7, 2016

In what time frame were these 60 transactions sent?

@ghost
Copy link
Author

ghost commented Dec 7, 2016

Of course less than 10s. For sure there was more than 25 sent in less than 10s

@jfernanz
Copy link

jfernanz commented Dec 7, 2016

Ok. Do this:

  • Send 100+ transactions instantly
  • Have the /api/transactions/unconfirmed windows open
  • Log the results and attach them here

@ghost
Copy link
Author

ghost commented Dec 7, 2016

Will do that tomorrow.
In meantime you can check video in #339 from test.

@karmacoma
Copy link
Contributor

@karek314 It is correct to say the "unconfirmed" transaction pool is limited to 25 as per block time and current block size. However, the maximum number of transactions that can be pooled on the network is much higher. This is behavior you are seeing is by design. Transaction processing and transaction broadcasts are queued and performed in stages, not immediately.

@ghost
Copy link
Author

ghost commented Dec 7, 2016

@karmacoma Thank you for your reply. Can you implement another field to that endpoint indicating real number of transactions awaiting to confirm ? Or design it to display all ?
Something like
{"success":true,"transactions":[],"count":0,"allPendingCount:"0}

@karmacoma
Copy link
Contributor

@karek314 Yes, we can add this. I agree it would be helpful to know, rather than querying each individual queue: unconfirmed, queued, multisignature.

@karmacoma karmacoma changed the title /api/transactions/unconfirmed - Limited to 25 Add queue counts to /api/transactions/unconfirmed Dec 7, 2016
MaciejBaj added a commit to MaciejBaj/lisk that referenced this issue Jan 3, 2017
Allows to see how many confirmed, unconfirmed, multisignature and queued transactions exists in particular moment via API call.

closes LiskArchive#341
@karmacoma karmacoma added this to the Core Sprint 01 milestone Jan 19, 2017
MaciejBaj added a commit to MaciejBaj/lisk that referenced this issue Jan 25, 2017
Allows to see how many confirmed, unconfirmed, multisignature and queued transactions exists in particular moment via API call.

closes LiskArchive#341
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants