Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement incoming connections limit #3720

Closed
diego-G opened this issue May 23, 2019 · 0 comments
Closed

Implement incoming connections limit #3720

diego-G opened this issue May 23, 2019 · 0 comments
Assignees

Comments

@diego-G
Copy link

diego-G commented May 23, 2019

Expected behavior

When an incoming peer connection arises, the peer pool should check if the current incoming connections are below the maximum of incoming connections allowed (maxInConnections). Otherwise, an eviction method must be triggered to randomly remove an ongoing connection and therefore allow the fresh one.

The parameter maxInConnections must be configurable, discouraging the users to modify it in any non-experimental scenario. The proposed default value is 100.

Actual behavior

The node allows as much connections as the hardware supports.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0+

@diego-G diego-G self-assigned this May 23, 2019
jondubois added a commit that referenced this issue Jun 7, 2019
…nection_limit

Implement maximum number of inbound peer connections - Closes #3720
@jondubois jondubois added this to the P2P robust peer selection milestone Jun 11, 2019
@diego-G diego-G closed this as completed Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants