Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Not checking if account is a multisign kill node #383

Closed
fix opened this issue Jan 9, 2017 · 0 comments · Fixed by #405
Closed

Not checking if account is a multisign kill node #383

fix opened this issue Jan 9, 2017 · 0 comments · Fixed by #405
Assignees
Milestone

Comments

@fix
Copy link
Contributor

fix commented Jan 9, 2017

[log] 2017-01-09 14:23:54 | POST /api/multisignatures/sign from 127.0.0.1
[FTL] 2017-01-09 14:23:54 | System error - {"message":"Cannot read property 'indexOf' of null","stack":"TypeError: Cannot read property 'indexOf' of null\n at Immediate. (/Users/vsat/git/lisk/lisk-node/modules/multisignatures.js:371:33)\n at runCallback (timers.js:641:20)\n at tryOnImmediate (timers.js:610:5)\n at processImmediate [as _immediateCallback] (timers.js:582:5)"}
[inf] 2017-01-09 14:23:54 | Cleaning up...
[inf] 2017-01-09 14:23:54 | Cleaned up successfully
[inf] 2017-01-09 14:23:54 | caught internal exit

was using old version of lisk, but the bug remain:

https://github.com/LiskHQ/lisk/blob/development/modules/multisignatures.js#L360

scope.sender.multisignatures is not checked if exists. So trying to sign as multi over a legit account which is not a multiaccount is killing the node

@MaciejBaj MaciejBaj self-assigned this Jan 9, 2017
MaciejBaj added a commit to MaciejBaj/lisk that referenced this issue Jan 10, 2017
Handle situation when sender has no multisignatures field.

closes LiskArchive#383
@karmacoma karmacoma added this to the Core Sprint 01 milestone Jan 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants