Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Investigate the impact and remove process.stdin.resume() #3839

Closed
nazarhussain opened this issue Jun 19, 2019 · 0 comments · Fixed by #4018
Closed

Investigate the impact and remove process.stdin.resume() #3839

nazarhussain opened this issue Jun 19, 2019 · 0 comments · Fixed by #4018

Comments

@nazarhussain
Copy link
Contributor

Expected behavior

Currently we have a usage of process.stdin.resume() in chain module. Which actually come from the legacy code.

https://github.com/LiskHQ/lisk-sdk/blob/942d320795d13cf0ad83e33d8e78c07357ae8700/framework/src/modules/chain/chain.js#L47-L48

While writing storage tests in jest I found out the test runner hangs up after the successful execution and it jest option --detectOpenHandles leads to above line.

For now I had limited it not block stdin during the tests. We should investigate the impact of it in the production environment and then remove it.

Actual behavior

We should not be holding off the stdin in any case.

Which version(s) does this affect? (Environment, OS, etc...)

3.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant