Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Only send back the port and ip when peer requests our peer list #3948

Closed
jondubois opened this issue Jul 11, 2019 · 0 comments
Closed

Only send back the port and ip when peer requests our peer list #3948

jondubois opened this issue Jul 11, 2019 · 0 comments
Assignees
@diego-G
Labels
elements/P2P
Milestone
Sprint 2

Comments

@jondubois
Copy link
Contributor

jondubois commented Jul 11, 2019 •
edited by sridharmeganathan
Loading

Expected behavior

When doing discovery, the peer should only give us a list of IPs and ports of its peers; it should not include the other fields from P2PPeerInfo.

We will fetch the remaining P2PPeerInfo fields after we connect to the peer and make a status call to it.

Actual behavior

Right now, for peers in our newPeers list, it's possible that the fields could be wrong because a different peer could give us fake values for the fields (they come from third-party peers and not the peer itself).

Currently, we shouldn't trust fields of P2PPeerInfo objects in the newPeers list.
@jondubois jondubois added this to the P2P resilience milestone Jul 17, 2019
@shuse2 shuse2 removed this from the P2P resilience milestone Jul 17, 2019
@diego-G diego-G self-assigned this Jul 23, 2019
@sridharmeganathan sridharmeganathan added this to the Sprint 3 milestone Jul 24, 2019
@diego-G diego-G mentioned this issue Jul 29, 2019
Merged
5 tasks
diego-G added a commit that referenced this issue Jul 30, 2019
@diego-G
Merge P2P feature into #3948
a0da74c
jondubois added a commit that referenced this issue Jul 31, 2019
@jondubois
Merge pull request #4017 from LiskHQ/3948-minimal_peers_list_data_on_…
1e5467c 
…discovery

Add get minimal peers list data for discovery process - Closes #3948
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
elements/P2P
Projects
None yet
Milestone
Sprint 2
Development

No branches or pull requests
4 participants
@jondubois @diego-G @shuse2 @sridharmeganathan