Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Endpoint getForgedByAccount not working as expected #396

Closed
4miners opened this issue Jan 19, 2017 · 0 comments
Closed

Endpoint getForgedByAccount not working as expected #396

4miners opened this issue Jan 19, 2017 · 0 comments
Assignees
@4miners
Labels
type: bug
Milestone
Version 0.6.0

Comments

@4miners
Copy link
Contributor

4miners commented Jan 19, 2017

That endpoint will not work correctly because b_totalFee is a block reward and not delegate reward (is not directly credited to delegate who forged that block). Delegate reward is calculated after completed round: round_total_fees/101*delegate_round_blocks_cnt (simplified). Need to be redesigned.

Connected:
#318
#343
@4miners 4miners self-assigned this Jan 19, 2017
@4miners 4miners mentioned this issue Jan 19, 2017
Merged
@karmacoma karmacoma added this to the Core Sprint 01 milestone Jan 19, 2017
@4miners 4miners added the ready label Jan 20, 2017
karmacoma added a commit that referenced this issue Jan 24, 2017
@karmacoma
Merge pull request #384 from 4miners/lisk-sql-1
b743cf5 
Closes #396. Fixed fees calculations in getForgedByAccount endpoint.
@karmacoma karmacoma removed the ready label Jan 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@4miners 4miners

Labels
type: bug
Projects
None yet
Milestone
Version 0.6.0
Development

No branches or pull requests
2 participants
@karmacoma @4miners